-
Notifications
You must be signed in to change notification settings - Fork 17
Hdf5 improvements #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
johltn
wants to merge
114
commits into
IfcOpenShell:master
Choose a base branch
from
johltn:hdf5_improvements
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
114 commits
Select commit
Hold shift + click to select a range
3b718ee
msvc 2019 and win build script fixes
aothms 60f309d
Create test for HDF libs
johltn daf138f
Abstract writer class with Hdf writer subclass
johltn f559f0c
Start iteration through continuous chunk
johltn 6b3baf5
Read bits stream and start with HDF5
johltn bac0607
Store bit values into HDF file
johltn dbe4e00
Hyperslab writing on fixed dataset dimensions and add test case
johltn 60d8a6e
Write multidimensional dataset for continuous chunks
johltn a1ba1c1
Use extents to write multidimensional HDF
johltn 4e8868a
Handle constant null storage chunks
johltn d27df88
Better control flow
johltn 426cbee
Merge remote-tracking branch 'upstream/master' into HDF5
johltn 9ff08b9
Count all chunks and make planar explicit
johltn e83e84a
Write bits incrementally
johltn 35298b1
Incrementally write dataset regions in Region dataset
johltn 85e9820
New test case
johltn 5433a71
Install hdf5
johltn e8537f5
Add pathes to include and lib dirs
johltn 290fc67
Add quotes
johltn 162fd65
Add subdir for include path
johltn 8ea1951
Move HDF installation variables
johltn e7a3c45
Libraries variable
johltn 5db0d4e
Update Travis file
johltn 413febf
Update Travis file
johltn 273444d
serial
johltn d4c996b
Replace lib name
johltn 39889c0
serial
johltn 55e002a
Update Travis file
johltn 99e967b
Add dl
johltn e5602bb
Fix iterations over chunks
johltn 952c57e
Fix region slabs dimensions
johltn c4e64e0
Tentative to incrementally write planar chunks to compound typed dataset
johltn 367f4ba
Planar dataset writing ok for simple example
johltn e018ef7
Start cleaning before cosntant chunks handling
johltn 7a41f0f
Writing preparation to constant chunks dataset
johltn 95d7c0d
Write constant chunks + region references
johltn b17dd73
Change dimensions types to comply with clang compilator
johltn 237ddb7
Modify control flow
johltn 1a6c326
Start handling voxels stored as integers
johltn 7bb7411
Store operations as groups containing chunk datasets
johltn 47ed3ad
option to specify padding
aothms a24873d
Delete appveyor.yml
aothms c7143b9
Create test for HDF libs
johltn 475fa6c
boolean operation fixes
aothms d447d40
decribe_components() zero() plane()
aothms 86bfbf4
Add missing include
aothms 7e54760
intersection fixes
aothms 5794a4d
describe_group_by()
aothms b8eeb33
Use {0,1} voxelset for traversal on PRODUCT_ID method
aothms 562fa5a
Fix hardcoded chunk size
aothms 98e1712
Add chunk size to log output
aothms 9ad66d4
shift() on uint storage
aothms c0b773d
sweep until
aothms 9d08e2c
constant_like(type=)
aothms 758b9e5
mesh(groups=)
aothms 20fdc74
Remove debugging
aothms 7d0b1cf
don't traverse chunks on max_depth
aothms 8269dd4
uint storage option for traversal
aothms c6fc6fa
export_csv()
aothms acba092
Abstract writer class with Hdf writer subclass
johltn abe3c74
Start iteration through continuous chunk
johltn a9d47d1
Read bits stream and start with HDF5
johltn a641a43
initialize num_threads
aothms d96acbf
don't assign to first when skipped over interval
aothms e5863c7
voxel storage copy_as() method
aothms 7fc4a33
multi-threaded geometry creation
aothms 8507748
multi threaded VOLUME_PRODUCT_ID
aothms 9e5e7d3
multi-threaded group_by()
aothms cbfa656
respect with_components in mesh()
aothms 292b870
copy(type=) command
aothms 914aefc
dist: focal
aothms ba17a9d
Update .travis.yml
aothms 3cda43d
Update .travis.yml
aothms 69a4f1c
Store bit values into HDF file
johltn 1343f77
Hyperslab writing on fixed dataset dimensions and add test case
johltn 7a15675
Write multidimensional dataset for continuous chunks
johltn c76b91d
don't attempt full chunk union on non-bit types
aothms 18957a4
print_values() debugging option
aothms e9df48a
more chunk union fixes
aothms f0cef42
Use extents to write multidimensional HDF
johltn 12438d1
Handle constant null storage chunks
johltn c2dea44
more optimal meshing in case of many chunks
aothms cd33f5f
Support for functions and small grammar changes
aothms 2640dc3
Better control flow
johltn 8120ab4
Count all chunks and make planar explicit
johltn fae86ec
Write bits incrementally
johltn b34b14a
Incrementally write dataset regions in Region dataset
johltn d462316
New test case
johltn 7ae6a5f
Install hdf5
johltn 05793b7
Add pathes to include and lib dirs
johltn e8d4f67
Add quotes
johltn ac94ad1
Add subdir for include path
johltn d58742b
Move HDF installation variables
johltn 05dd057
Libraries variable
johltn d761235
Update Travis file
johltn 94d7c0a
Update Travis file
johltn 80cc06c
serial
johltn 866d716
Replace lib name
johltn c04b2e4
serial
johltn 1f7a652
Update Travis file
johltn 59281bd
Add dl
johltn 92f1eec
Fix iterations over chunks
johltn 835a060
Fix region slabs dimensions
johltn d4012d0
Tentative to incrementally write planar chunks to compound typed dataset
johltn d196c31
Planar dataset writing ok for simple example
johltn db46840
Start cleaning before cosntant chunks handling
johltn b387a4c
Writing preparation to constant chunks dataset
johltn 075e55d
Write constant chunks + region references
johltn 6e81854
Change dimensions types to comply with clang compilator
johltn 3d62d8b
Modify control flow
johltn 612ced3
Start handling voxels stored as integers
johltn b6da6f3
Store operations as groups containing chunk datasets
johltn 43f2dd1
Merge branch 'opensourceBIM:HDF5' into HDF5
johltn 163d991
Voxelization toolkit works with IfcOpenShell v0.7.0 including HDF sup…
johltn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Start cleaning before cosntant chunks handling
- Loading branch information
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find all these variable declarations not immensely useful. I know they do it in the samples, but for me it creates an extra indirection between NX and storage->chunk_size(), I'd rather have a more meaningful name for the variables so that we understand the intent.
I'd also prefer the syntax:
And please remove all the unnecessary spaces between type and variable name. If any of them remain after the reorganization.
dimsf[RANK]
for consistencyWith this advise most of the lines can be eliminated making it much more clear for the casual reader what's going on.