Feature filter rows by inequality. #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows rudimentary filtering of rows using inequalities, in Caves & Cavers, on columns Views & Count respectively. Added comments to `search` methods that attempt point out the goofy nature of that function, i.e. that it needs to return `false` generally, and that we only return `true` if there is something we want to _not_ display there by only displaying what matches our search criteria. Not sure exactly why I wrote it that way. Updated .gitignore to exclude tags file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows rudimentary filtering of rows using inequalities, in Caves &
Cavers, on columns Views & Count respectively.
Added comments to
searchmethods that attempt point out the goofynature of that function, i.e. that it needs to return
falsegenerally, and that we only return
trueif there is something wewant to not display there by only displaying what matches our
search criteria. Not sure exactly why I wrote it that way.
Updated .gitignore to exclude tags file.