Merged
Conversation
Update branch
Update branch
…ty called WeightedJaccardIndex
…t into its own function.
…nged name of MineRoles to SummarizeRoles. Changed most classes, and removed unused classes. Created an interface for the tests, and created new tests for the changed algorithms.
… before returning.
ragnarstolsmark
requested changes
Sep 25, 2024
Contributor
ragnarstolsmark
left a comment
ragnarstolsmark
left a comment
There was a problem hiding this comment.
Da var jeg ferdig med min gjennomgang. Det var mye bra, men litt å ta tak i.
ragnarstolsmark
requested changes
Oct 4, 2024
Contributor
ragnarstolsmark
left a comment
ragnarstolsmark
left a comment
There was a problem hiding this comment.
Da er du nesten i mål. Et par småting som gjenstår for å bli kvitt advarslene til github.
DanyGoT
force-pushed
the
algorithmic-access-bake-to-role
branch
from
403249f to
155b933
Compare
Contributor
ragnarstolsmark
left a comment
ragnarstolsmark
left a comment
There was a problem hiding this comment.
Snart der igjen :)
Contributor
|
Det viste seg å være noen konflikter som hindret meg i å få det inn på main-branchen. Du må rebase branchen. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.