order by predicate to prevent table scan

[edmacdonald]

See #5091

This block is resulting in a full scan during clean up:

IdentityServer4/src/EntityFramework.Storage/src/TokenCleanup/TokenCleanupService.cs

Lines 77 to 81 in 07898a6

	var expiredGrants = await _persistedGrantDbContext.PersistedGrants
	.Where(x => x.Expiration < DateTime.UtcNow)
	.OrderBy(x => x.Key)
	.Take(_options.TokenCleanupBatchSize)
	.ToArrayAsync();

Sorting by the same column used in the predicate fixes it

                var expiredGrants = await _persistedGrantDbContext.PersistedGrants
                    .Where(x => x.Expiration < DateTime.UtcNow)
                    .OrderBy(x => x.Expiration)
                    .Take(_options.TokenCleanupBatchSize)
                    .ToArrayAsync();

[edmacdonald]

@brockallen here's a comparison of the query plans if that helps. Changing the Order By makes it about 100 times more efficient. Note that this was taken during a "quiet time" so the 60k rows read gets much worse for us when it's busy.
https://www.brentozar.com/pastetheplan/?id=H1d80r93D

[leastprivilege]

Hi

thanks! Sorry, took a while.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.