Introduce cryptography module #526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This module provides cryptographic elements needed by saml2. There are separate modules for symmetric and asymmetric cryptography, as well as pki related operations. The default symmetric cryptography method used is Fernet by the cryptography library. Reference: https://cryptography.io/en/latest/fernet/ Signed-off-by: Ivan Kanakarakis <ivan.kanak@gmail.com>
Replace AESCipher with the default symmetric method. Use the default key generation method to generate a key for the server. Warn about the use of aes attribute of authn.UsernamePasswordMako class. Hide cryptography details behind the saml2.cryptography module. Signed-off-by: Ivan Kanakarakis <ivan.kanak@gmail.com>
aes.py is deprecated and will be completely removed in a following release. Users should switch to saml2.cryptography.symmetric instead. Signed-off-by: Ivan Kanakarakis <ivan.kanak@gmail.com>
c00kiemon5ter
force-pushed
the
refactor-cryptography-module
branch
from
6422e25 to
a7763cd
Compare
Codecov Report
@@ Coverage Diff @@
## master #526 +/- ##
==========================================
+ Coverage 65.47% 65.51% +0.03%
==========================================
Files 100 103 +3
Lines 25635 25681 +46
==========================================
+ Hits 16785 16825 +40
- Misses 8850 8856 +6
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based off of #519
AESCipherRelated discussions at #519 and #417
All Submissions: