Skip to content
This repository was archived by the owner on Jun 23, 2023. It is now read-only.

Version 2.1.0 #109

Merged
merged 21 commits into from
Jul 5, 2021
Merged

Version 2.1.0 #109

merged 21 commits into from
Jul 5, 2021

Conversation

rohe
Copy link
Collaborator

@rohe rohe commented Jul 4, 2021

Fixed a couple of backward compatibility issues. Like accepting old tokens and allowing configuration of a client database separate from the session database.
Also made sure that if an acr value was specified using the claims parameter in authorization request, it would be honoured and reported back in the ID Token or in the response from the user info endpoint.

@rohe rohe requested review from peppelinux and nsklikas July 4, 2021 13:32
@peppelinux
Copy link
Member

Great, do we have to label as BREAKING CHANGE the new cdb approach?

Is there something to explain in the docs?

@peppelinux
Copy link
Member

I mean here
https://github.com/IdentityPython/oidc-op/pull/109/files#diff-0731523b7d97b481325cebda9df3e709982a684ddcaf77f73eeadd5e2a05c377R160

do we have to say that load/dump/flush methods MUST be adopted and this approach could be breaking for the implementers?

Copy link
Member

@peppelinux peppelinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall the code looks pretty ginvolvedood, great job Roland

@rohe
Copy link
Collaborator Author

rohe commented Jul 4, 2021

The new cdb approach isn't breaking anything. It allows new functionality that is what it does.
I rewrote AbstractFileSystem compared to previous usage to also have the dump/load methods. Not flush. Went back and forth on that but decided eventually not to support it.
If cdb is a class instance then the class must support dump and load.

@peppelinux
Copy link
Member

It looks very good to me, thank you

@peppelinux
Copy link
Member

tested on django-oidc-op, all passes, very good

@rohe rohe merged commit 41d7f5e into master Jul 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants