OAuth2 Client code refactoring and linting #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that the RFC says: 'The content of the response body is ignored by the client as all necessary information is conveyed in the response code.'. So we should not put information in the response.
Remove response_types containing 'token'
Two new tests/demos.
…s when running demos.
…s when running demos.
Make the client take notice on what the OP says about which endpoints it supports.
Make the client take notice on what the OP says about which endpoints it supports.
Note that the RFC says: 'The content of the response body is ignored by the client as all necessary information is conveyed in the response code.'. So we should not put information in the response.
Remove response_types containing 'token'
Two new tests/demos.
…s when running demos.
…s when running demos.
Make the client take notice on what the OP says about which endpoints it supports.
Make the client take notice on what the OP says about which endpoints it supports.
Apart from the nonce bit.
Added a new exception.
Add ons should all store information in the same way. Two new demo scripts. Different response_types.
Removed parts of configurations that wasn't needed/used. Started on a README file.
Added more text to README.md . Handled the case that refresh token was not part of the configuration.
Have to work a bit more on PAR.
Run isort and black
Made a directory with scripts that display idpyoidc functionality
Signed-off-by: Kostis Triantafyllakis <kostastriantaf@gmail.com>
Signed-off-by: Kostis Triantafyllakis <kostastriantaf@gmail.com>
…ly talk to one OP/AS.
response_type is about what's returned. response_mode is how.
Add fixes on PKCE and client_authn
Option for audience restriction enforcement
Dealt with getting a jwks_uri in a static provider info configuration. Response_types as list or space separated string should both work.
…n/idpy-oidc into stand_alone_client
Stand alone client
peppelinux
approved these changes
Jul 13, 2023
There was a problem hiding this comment.
This PR brings a lot of new stuffs and stuffs developed in the past that is now ready to be released
the review took some attention in reading since the blake linting made a lot of changes, however it seems to me that this PR is ready to be tested more in the deep
ctriant
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.