Update views.py #297
Merged
Update views.py #297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed from error to debug
peppelinux
added a commit
that referenced
this pull request
Jun 20, 2021
* Update views.py (#297) changed from error to debug * Unsupported Binding exception in SLO There's the possibility that an IdP doesn't support the SLO, added an exception handling as a workaround for this. Now we have in the log something like: ```` Unsupported binding: None (https://172.17.0.1:10000/Saml2IDP/metadata) Error Handled - SLO - unsupported binding by IDP: None Traceback (most recent call last): File "~/DEV/IdentityPython/env/lib/python3.8/site-packages/djangosaml2/views.py", line 601, in get result = client.global_logout(subject_id) File "~/DEV/IdentityPython/env/lib/python3.8/site-packages/saml2/client.py", line 210, in global_logout return self.do_logout( File "~/DEV/IdentityPython/env/lib/python3.8/site-packages/djangosaml2/overrides.py", line 25, in do_logout return super().do_logout(*args, **kwargs) File "~/DEV/IdentityPython/env/lib/python3.8/site-packages/saml2/client.py", line 259, in do_logout bindings_slo_supported = self.metadata.single_logout_service( File "~/DEV/IdentityPython/env/lib/python3.8/site-packages/saml2/mdstore.py", line 1236, in single_logout_service return self.service(entity_id, "%s_descriptor" % typ, File "~/DEV/IdentityPython/env/lib/python3.8/site-packages/saml2/mdstore.py", line 1147, in service raise UnsupportedBinding(binding) saml2.s_utils.UnsupportedBinding: None ```` * v1.3.2 Co-authored-by: sur.la.route <christopher.pickering@keemail.me>
peppelinux
added a commit
that referenced
this pull request
Jun 27, 2021
* Update views.py (#297) changed from error to debug * Unsupported Binding exception in SLO There's the possibility that an IdP doesn't support the SLO, added an exception handling as a workaround for this. Now we have in the log something like: ```` Unsupported binding: None (https://172.17.0.1:10000/Saml2IDP/metadata) Error Handled - SLO - unsupported binding by IDP: None Traceback (most recent call last): File "~/DEV/IdentityPython/env/lib/python3.8/site-packages/djangosaml2/views.py", line 601, in get result = client.global_logout(subject_id) File "~/DEV/IdentityPython/env/lib/python3.8/site-packages/saml2/client.py", line 210, in global_logout return self.do_logout( File "~/DEV/IdentityPython/env/lib/python3.8/site-packages/djangosaml2/overrides.py", line 25, in do_logout return super().do_logout(*args, **kwargs) File "~/DEV/IdentityPython/env/lib/python3.8/site-packages/saml2/client.py", line 259, in do_logout bindings_slo_supported = self.metadata.single_logout_service( File "~/DEV/IdentityPython/env/lib/python3.8/site-packages/saml2/mdstore.py", line 1236, in single_logout_service return self.service(entity_id, "%s_descriptor" % typ, File "~/DEV/IdentityPython/env/lib/python3.8/site-packages/saml2/mdstore.py", line 1147, in service raise UnsupportedBinding(binding) saml2.s_utils.UnsupportedBinding: None ```` * v1.3.2 * chore: Documentation improvements that fixed #231 and #299 (@tkloda) Co-authored-by: sur.la.route <christopher.pickering@keemail.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changed from error to debug