Skip to content

Fix default relay state bug #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2021

Conversation

lgarvey
Copy link
Contributor

@lgarvey lgarvey commented Mar 8, 2021

If not defined the relaystate was always defaulting to / despite settings.LOGIN_REDIRECT_URL being set.

If not defined the relaystate was always defaulting to / despite settings.LOGIN_REDIRECT_URL being set.
@lgarvey
Copy link
Contributor Author

lgarvey commented Mar 8, 2021

This PR fixes the issue I face - e.g. being able to set a redirect URL but as a result this code will never get hit:

https://github.com/peppelinux/djangosaml2/pull/253/files#diff-14e9a5c86c429d4f469f5e22f7c2c4b239e52569a920f15c58513f2d2a216332R438-R439

Is it important to log that RelayState was not provided?

Either I could remove the check/logging statement (lines 438/439) or restructure it so that it is correctly aware if the incoming request has no relay state.

@peppelinux
Copy link
Member

Please rebase to Dev branch.
Sounds good and I'd also appreciate a unittest.
Probably this PR Will need some review but yes, looks good

@lgarvey lgarvey changed the base branch from master to dev March 9, 2021 09:45
@peppelinux peppelinux merged commit 5ab385b into IdentityPython:dev Mar 9, 2021
@lgarvey
Copy link
Contributor Author

lgarvey commented Mar 9, 2021

@peppelinux This still needs a test and clearing up the logging section. I'll raise another PR! :)

PS. UniAuth looks interesting.

@peppelinux
Copy link
Member

I'll wait for a PR with the test in the meanwhile.
uniAuth is quite monolitich and it would be refactored to be a django app but, at the same time, I think that a monolitich IdP is the scope of uniAuth... so I feel quite torn about this.

The next release of djangosaml2 will take some weeks, so, time is not a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants