Add an option to ignore logout errors #227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like it, can I ask you to cover this feature with some unit tests? |
|
I tried to write tests but I couldn't find any logout-related scenarios in the test suite and I'm not sure how to approach this |
|
Please open an Issue to document this kind of request for the future releases, We'll keep this ToDo |
|
reference this PR as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the IDP session time is shorter than the Django session time, logout from Django will trigger an SAML logout error.
There are use cases, such as an IDP being used for a single application, where not being able to successfully logout from the IDP is not a big issue. So I am proposing an option that lets the Django logout flow continue even when SAML logout could not be performed successfully