Consider resolving LOGIN_REDIRECT_URL

[jaap3]

In our application LOGIN_REDIRECT_URL is a named URL pattern (this is allowed according to the Django docs).

Please consider using django.shortcuts.resolve_url before returning its value in djangosaml2.utils.validate_referral_url.

[peppelinux]

Hi @jaap3 I found an issues when urls.py imports django settings and this latter needs to resolve an URL. This would create a circular import and a not clear exception to developers

That's why I assume this as a weakness, because a single APP doesn't erally knows if in a project there will be some settings imports in urls.

Feel free to share any additional hint to improve my vision, I'll keep this issue open

[jaap3]

Hi, I'm not sure what you are saying... in settings.py LOGIN_REDIRECT_URL is configured to be something like 'accounts:dashboard' (so no reverse call is being made). This works with the standard Django LoginView because it always calls resolve_url at the moment it is used.

I'm suggesting to do something similar in djangosaml2. The most logical place to me seems validate_refarral_url as it now returns the exact value of LOGIN_REDIRECT_URL. Another option would be to call resolve_url in djangosaml2's own LoginView.get_next_path.

Note that django.shortcuts.resolve_url works with concrete urls (it will just return them as is) and named url patterns. So there should be no functionality change for projects that have a "real" url configured as the LOGIN_REDIRECT_URL, it will just make sure djangosaml2 works in a similar way as Django's standard LoginView.

[peppelinux]

Ok, got it, sorry If I misunderstood your claim, I think that would be a good feature as well
Would you like to push a PR for this?

[jaap3]

Yes, I can probably find some time to work on a PR for this.

[pandafy]

I just came here to open this issue. This will indeed be a good addition. :)

[peppelinux]

I think that this issue and other two should be fixed in next release 1.3.0, I put it in this milestone.
@pandafy and @jaap3 I think that we're a good team for the next release, I'd really appreciate your help, djangosaml2 is a community driven software and without us it would no longer exist, so, I really apreciate your help 👍