Select preferred binding on the configuration #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pysaml2 supports the configuration option 'preferred_binding' which is
a map of services to array of preferred bindings for that service. Use
the configuration instead of the currently hardcoded choices.
An example configuration would be the following:
module: satosa.backends.saml2.SAMLBackend
name: Saml2
config:
sp_config:
preferred_binding:
single_sign_on_service:
- urn:oasis:names:tc:SAML:2.0:bindings:HTTP-Redirect
- urn:oasis:names:tc:SAML:2.0:bindings:HTTP-POST
This defines the preferred bindings for the SSO service, and is
equivalent the code that was hardcoded before. Changing the order of the
bindings would use HTTP-POST instead of the HTTP-Redirect.
c00kiemon5ter
force-pushed
the
feature-preferred-binding
branch
from
8c0347e to
7046ceb
Compare
|
LGTM
…On Jul 19, 2017 17:26, "Ivan Kanakarakis" ***@***.***> wrote:
pysaml2 supported the configuration option preferred_binding which is a
map of services to array of preferred bindings for that service. Use the
configuration instead of the currently hardcoded choices.
An example configuration would be the following:
module: satosa.backends.saml2.SAMLBackend
name: Saml2
config:
sp_config:
preferred_binding:
single_sign_on_service:
- urn:oasis:names:tc:SAML:2.0:bindings:HTTP-Redirect
- urn:oasis:names:tc:SAML:2.0:bindings:HTTP-POST
This defines the preferred bindings for the SSO service, and is equivalent
the code that was hardcoded before. Changing the order of the bindings
would use HTTP-POST instead of the HTTP-Redirect.
------------------------------
You can view, comment on, or merge this pull request online at:
#120
Commit Summary
- Select preferred binding on the configuration
File Changes
- *M* src/satosa/backends/saml2.py
<https://github.com/SUNET/SATOSA/pull/120/files#diff-0> (7)
Patch Links:
- https://github.com/SUNET/SATOSA/pull/120.patch
- https://github.com/SUNET/SATOSA/pull/120.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#120>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJzhKDUjUjJv-0L4hNu3zTlDznn5qsvpks5sPhINgaJpZM4Ocz3n>
.
|
|
Note that this configuration option is undocumented on the |
Care to open an issue/PR there too ? |
|
Yes, I will |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pysaml2supports the configuration optionpreferred_bindingwhich is a map of services to array of preferred bindings for that service. Use the configuration instead of the currently hardcoded choices.An example configuration would be the following:
This defines the preferred bindings for the SSO service, and is equivalent the code that was hardcoded before that is also the default behaviour of
pysaml2. Changing the order of the bindings would useHTTP-POSTinstead of theHTTP-Redirect.You can see the preferred_binding service names map here:
https://github.com/rohe/pysaml2/blob/master/src/saml2/config.py#L139-L156