Skip to content
This repository was archived by the owner on Jun 1, 2023. It is now read-only.

Conversation

@rohe
Copy link
Collaborator

@rohe rohe commented May 11, 2021

Common configuration functionality to reside in oidcmsg instead of being duplicated in oidcrp and oidcop

@codecov-commenter
Copy link

codecov-commenter commented May 11, 2021

Codecov Report

Merging #34 (d8ba736) into master (c7a8d42) will increase coverage by 0.52%.
The diff coverage is 77.37%.

❗ Current head d8ba736 differs from pull request most recent head 6c898e8. Consider uploading reports for the commit 6c898e8 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
+ Coverage   66.75%   67.27%   +0.52%     
==========================================
  Files          20       23       +3     
  Lines        2725     2857     +132     
==========================================
+ Hits         1819     1922     +103     
- Misses        906      935      +29     
Impacted Files Coverage Δ
src/oidcmsg/impexp.py 75.22% <11.11%> (-4.22%) ⬇️
src/oidcmsg/util.py 62.50% <62.50%> (ø)
src/oidcmsg/logging.py 68.18% <68.18%> (ø)
src/oidcmsg/configure.py 86.31% <86.31%> (ø)
src/oidcmsg/__init__.py 51.16% <100.00%> (+1.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7a8d42...6c898e8. Read the comment docs.

@peppelinux peppelinux self-requested a review May 12, 2021 08:46
@rohe rohe merged commit 857fd56 into master May 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants