This repository has been archived by the owner on Mar 3, 2022. It is now read-only.
Fix _mergeClaims to prevent duplication of claims #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync with base fork
Given you want to merge two lists, when they share one claim but the claim contains common and an extra claim, and another claim in the second claim-object, then you get a result with duplicate claims lists with duplicate claims
Merges the left object with the current right object, then adding to the final result claim.
|
Cool, thanks! |
|
1.7.0-beta.1 has been published to npm, please test and see if it's working for you. |
|
Tested custom claims in the VanillaJS-project with the changes in 1.7.0-beta.1 now. Works as expected. |
|
FYI, in the upcoming release this PR's behavior will be reverted, but there will be a flag/option to re-enable it. |
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #703.
Added failing test with the repro-case from #703, and fixed the duplication of claims when given an array of custom claims from the IdP and expecting a single normalized claims-list as the result.
Ran tests and also performed browser-testing using the VanillaJS-sample projects.