notjQuery.js: Return a promise in trigger()#379
Merged
Conversation
nilmerg
force-pushed
the
add-promise-support-to-notjQuery-trigger
branch
from
051abbc to
e31f47f
Compare
nilmerg
force-pushed
the
add-promise-support-to-notjQuery-trigger
branch
from
e31f47f to
707ce62
Compare
This allows callers to e.g. cleanup after the bubbling phase. It is now also possible to disallow cancellation and prevent bubbling. Cancellation makes only sense now to begin with, as the resolved value will indicate whether a listener called `preventDefault()` or not.
nilmerg
force-pushed
the
add-promise-support-to-notjQuery-trigger
branch
from
f797e20 to
15c31e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows callers to e.g. cleanup after the bubbling phase.
It is now also possible to disallow cancellation and prevent bubbling. Cancellation makes only sense now to begin with, as the resolved value will indicate whether a listener called
preventDefault()or not.