Modernize code #96
Open
Modernize code #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukhwinder33445
force-pushed
the
modernize-code
branch
2 times, most recently
from
eefa5b5 to
8686b59
Compare
|
The |
BastianLedererIcinga
force-pushed
the
support-php-8.4/8.5
branch
from
db90247 to
204a7aa
Compare
sukhwinder33445
force-pushed
the
modernize-code
branch
from
21ca328 to
c248141
Compare
sukhwinder33445
force-pushed
the
modernize-code
branch
3 times, most recently
from
589584f to
c0df0ec
Compare
BastianLedererIcinga
force-pushed
the
support-php-8.4/8.5
branch
from
ef5f5f3 to
9b2ebce
Compare
BastianLedererIcinga
force-pushed
the
support-php-8.4/8.5
branch
from
9b2ebce to
9fc16d4
Compare
|
The rest looks good. |
BastianLedererIcinga
force-pushed
the
modernize-code
branch
from
c0df0ec to
e1a3680
Compare
sukhwinder33445
force-pushed
the
modernize-code
branch
from
e1a3680 to
8bee499
Compare
…acements, if they are available for the current PHP version
`scanDirectories` was set to `/usr/share/icinga-php` to simplify local testing, as both the Icinga PHP Library and Icinga PHP Thirdparty are installed there in our development environment. Our individual PHP library components, which make up these libraries, are self-contained, as they define all necessary dependencies themselves. This then requires testing with exactly these dependencies instead of an arbitrary folder that could contain anything, e.g., dependencies in unexpected versions or dependencies that have not yet been defined. For remote and local testing, `composer install` must be executed and tests must be performed with exactly the resulting dependencies. Since PHPStan uses the Composer autoloader by default, if available, `scanDirectories` does not need to be defined at all. - #93 makes it superfluous for github actions
BastianLedererIcinga
force-pushed
the
support-php-8.4/8.5
branch
from
9fc16d4 to
be685ed
Compare
- Use [] instead of list()
- This was only introduced to reduce phpstan errors.
- Remove now obsolete throw annotation and imports
sukhwinder33445
force-pushed
the
modernize-code
branch
from
8bee499 to
891337c
Compare
BastianLedererIcinga
approved these changes
Dec 11, 2025
BastianLedererIcinga
force-pushed
the
support-php-8.4/8.5
branch
2 times, most recently
from
2ebbbb8 to
9aaf2fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.