Skip to content

Conversation

sukhwinder33445
Copy link
Contributor

@sukhwinder33445 sukhwinder33445 commented Aug 15, 2025

fixes #460

Removing child nodes should not affect display of root nodes
@sukhwinder33445 sukhwinder33445 self-assigned this Aug 15, 2025
@cla-bot cla-bot bot added the cla/signed label Aug 15, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes issue #460 by modifying the NodeRemoveAction class to only adjust display order when removing root nodes. Previously, the code would attempt to adjust display order for any removed node, but now it specifically checks if the removed node is a root node before performing display order adjustments.

  • Adds a check to verify if the removed node is a root node before adjusting display order
  • Removes unnecessary variable $oldDisplay and replaces it with $removedNodeDisplay
  • Simplifies the logic by directly accessing the node's display value at the point of use

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@slalomsk8er
Copy link

Since I applied the patch I didn't get any Unbound nodes even if I used "Delete all occurrences of ...".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Delete all occurrences messes up the configuration and creates Unbound nodes

2 participants