TimePeriod/ScheduledDowntime: improve DST handling #9253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many functions of LegacyTimePeriod take a tm pointer as an input parameter and then pass it to mktime() which actually modifies it. This causes problems if tm_isdst was intentionally set to -1 (to automatically detect whether DST is active at some time) and then a function is called that implicitly sets tm_isdst and then the values of tm are modified in a way that crosses a DST change. This resulted in 1 hour offsets with ScheduledDowntimes on days with DST changes.
icinga-probot
bot
added
area/runtime
julianbrost
approved these changes
Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #8921