Fix scheduling of downtimes for all services on child hosts #9184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The loop iterated over the services of the wrong host resulting in duplicate downtimes scheduled for services of the parent host instead of downtimes for services of the child host.
icinga-probot
bot
added
area/runtime
julianbrost
approved these changes
Jan 21, 2022
icinga-probot
bot
deleted the
bugfix/downtime-all-services-on-child-hosts-212
branch
julianbrost
added a commit
that referenced
this pull request
Apr 19, 2022
PR #9184 backported a call to that function as is without considering the different signature of that function between 2.12 and 2.13+. master: static Ptr AddDowntime( const intrusive_ptr<Checkable>& checkable, // childService const String& author, // author const String& comment, // comment double startTime, // startTime double endTime, // endTime bool fixed, // fixed const String& triggeredBy, // triggerName double duration, // duration const String& scheduledDowntime = String(), // String() const String& scheduledBy = String(), // String() const String& parent = String(), // childDowntimeName const String& id = String(), const MessageOrigin::Ptr& origin = nullptr ); support/2.12 without this commit: static Ptr AddDowntime( const intrusive_ptr<Checkable>& checkable, // childService const String& author, // author const String& comment, // comment double startTime, // startTime double endTime, // endTime bool fixed, // fixed const String& triggeredBy, // triggerName double duration, // duration const String& scheduledDowntime = String(), // String() const String& scheduledBy = String(), // String() const String& id = String(), // childService const MessageOrigin::Ptr& origin = nullptr ); support/2.12 with this commit: static Ptr AddDowntime( const intrusive_ptr<Checkable>& checkable, // childService const String& author, // author const String& comment, // comment double startTime, // startTime double endTime, // endTime bool fixed, // fixed const String& triggeredBy, // triggerName double duration, // duration const String& scheduledDowntime = String(), const String& scheduledBy = String(), const String& id = String(), const MessageOrigin::Ptr& origin = nullptr );
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #8990