Skip to content

Make MySQL schema version in full schema file and upgrade files consistent (2.12) #9140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 10, 2022

Conversation

julianbrost
Copy link
Contributor

In the 2.12.6 release, the full schema file sets the version to 1.14.3, whereas the latest available upgrade file 2.11.0.sql sets it to 1.15.0. Therefore, ship a new upgrade file 2.12.7.sql for all users who imported their schema with version 2.11.0 or later and never performed an upgrade since then. Their databases incorrectly state schema version 1.14.3 and is bumped to the correct version 1.15.0 by the upgrade. Additionally, the version number in the full schema is also bumped to the correct version 1.15.0.

backport of #9138

…stent

In the 2.12.6 release, the full schema file sets the version to 1.14.3, whereas
the latest available upgrade file 2.11.0.sql sets it to 1.15.0. Therefore, ship
a new upgrade file 2.12.7.sql for all users who imported their schema with
version 2.11.0 or later and never performed an upgrade since then. Their
databases incorrectly state schema version 1.14.3 and is bumped to the correct
version 1.15.0 by the upgrade. Additionally, the version number in the full
schema is also bumped to the correct version 1.15.0.
@julianbrost
Copy link
Contributor Author

Note for review: Please perform a combined review of #9138, #9139, and #9140 and double check the following as this isn't the first time we're trying to fix it and we haven't got this right so far:

  • If an upgrade file exists in two branches, it has the same contents in both branches.
  • In each branch, the schema version is consistent between the full schema file and the latest upgrade file.
  • The latest upgrade file has a schema version greater than or equal to the previous upgrade file.
  • That version number is the correct one for that branch.

It's also critical to include all PRs in the 2.12.7 and 2.13.3 releases and to avoid other schema changes, otherwise these PRs become outdated.

Copy link
Member

@Al2Klimov Al2Klimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to match #8956 (comment) and #8956 (comment).

@julianbrost julianbrost changed the title Make MySQL schema version in full schema file and upgrade files consistent Make MySQL schema version in full schema file and upgrade files consistent (2.12) Jan 3, 2022
@julianbrost julianbrost merged commit 40eb116 into support/2.12 Jan 10, 2022
@icinga-probot icinga-probot bot deleted the bugfix/mysql-schema-versions-2.12 branch January 10, 2022 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/db-ido Database output bug Something isn't working cla/signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants