Update ITL CheckCommands for Thola

[babos77]

Thola has received several new features since its check commands have been added to the ITL. We have updated the commands and added new arguments and check commands that are now available.

New check commands:

• thola-disk
• thola-server
• thola-snmp

[cla-bot]

Thank you for your pull request. Before we can look at it, you'll need to sign a Contributor License Agreement (CLA).

Please follow instructions at https://icinga.com/company/contributor-agreement to sign the CLA.

After that, please reply here with a comment and we'll verify.

Contributors that have not signed yet: @babos77

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Please contact us if you think this is the case.

• If you signed the CLA as a corporation, your GitHub username may not have been submitted to us. Please reach out to the responsible person in your organization.

[babos77]

CLA signed

[bobapple]

@cla-bot check

[Al2Klimov]

@Yonas-net Next week if/while you have no priority tasks, review this first. (Squashing commits not necessary at all!)

[TheFireMike]

Any updates on this?

[yhabteab]

Having all of these template arguments (counted 26 args) being documented (duplicated) 12 times is beyond the pale IMO. We need to find a better way how to document the template args only once nicely and to mention somehow everywhere where the templates are used.

Your opinion is needed @Al2Klimov and @julianbrost !

[Al2Klimov]

Full ack.

[julianbrost]

Sounds like a plan. There's a section for Thola already, so making a subsection for common parameters there and referencing it totally makes sense. This will also better highlight which parameters are actually relevant for the individual checks as you're probably adding more than one check for a device anyways, so I think you'll end up settings thola_api_* and thola_device_* in the Host objects anyways.