Skip to content

ScheduledDowntime::TimerProc(): Catch exceptions to make sure other downtimes are still created #8863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2021
Merged

ScheduledDowntime::TimerProc(): Catch exceptions to make sure other downtimes are still created #8863

merged 1 commit into from
Jul 7, 2021

Conversation

Al2Klimov
Copy link
Member

@Al2Klimov Al2Klimov self-assigned this Jul 2, 2021
@icinga-probot icinga-probot bot added this to the 2.12.5 milestone Jul 2, 2021
@icinga-probot icinga-probot bot added area/runtime Downtimes, comments, dependencies, events bug Something isn't working consider backporting Should be considered for inclusion in a bugfix release labels Jul 2, 2021
@Al2Klimov
Copy link
Member Author

Blocked by

@Al2Klimov Al2Klimov force-pushed the bugfix/harden-scheduled-downtimes-212 branch 2 times, most recently from e5df130 to 9294b78 Compare July 5, 2021 14:20
@Al2Klimov Al2Klimov removed their assignment Jul 5, 2021
@Al2Klimov Al2Klimov requested a review from julianbrost July 5, 2021 14:31
@Al2Klimov Al2Klimov marked this pull request as ready for review July 6, 2021 08:24
julianbrost
julianbrost requested changes Jul 6, 2021
View reviewed changes
lib/icinga/scheduleddowntime.cpp Outdated
@@ -88,7 +88,13 @@ void ScheduledDowntime::TimerProc()
{
for (const ScheduledDowntime::Ptr& sd : ConfigType::GetObjectsByType<ScheduledDowntime>()) {
if (sd->IsActive() && !sd->IsPaused())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you backported an old version of the PR branch, the latest one has curly braces for this if.

@Al2Klimov Al2Klimov force-pushed the bugfix/harden-scheduled-downtimes-212 branch from 9294b78 to 7e0eab3 Compare July 6, 2021 10:27
@Al2Klimov Al2Klimov requested a review from julianbrost July 6, 2021 10:28
@N-o-X N-o-X removed the consider backporting Should be considered for inclusion in a bugfix release label Jul 6, 2021
@Al2Klimov Al2Klimov mentioned this pull request Jul 6, 2021
Merged
@N-o-X N-o-X merged commit 4fb27a4 into support/2.12 Jul 7, 2021
@icinga-probot icinga-probot bot deleted the bugfix/harden-scheduled-downtimes-212 branch July 7, 2021 08:40
@Al2Klimov Al2Klimov mentioned this pull request Jul 7, 2021
Closed
@julianbrost julianbrost mentioned this pull request Sep 9, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianbrost julianbrost julianbrost approved these changes

Assignees
No one assigned
Labels
area/runtime Downtimes, comments, dependencies, events bug Something isn't working
Projects
None yet
Milestone
2.12.5
Development

Successfully merging this pull request may close these issues.
3 participants
@Al2Klimov @julianbrost @N-o-X