Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay start of IcingaDB until most config objects are activated #8602

Merged
merged 1 commit into from
Jan 28, 2021

Conversation

julianbrost
Copy link
Contributor

@julianbrost julianbrost commented Jan 19, 2021

This commit sets the activation priority if IcingaDB objects to 100 (the same value as IDO uses) so that it get's activated after most regular config objects (hosts, services, ...).

Before (note how Icinga 2 continues to active objects for over a minute after IcingaDB is started and thinks the initial dump is done):

[2021-01-19 08:33:19 +0000] information/IcingaDB: 'icingadb' started.
[2021-01-19 08:34:02 +0000] information/IcingaDB: Initial config/status dump finished in 28.247 seconds.
[2021-01-19 08:35:49 +0000] information/ConfigItem: Activated all objects.

After (now activation of objects is done right after IcingaDB is started, as it's one of the last objects to be activated):

[2021-01-19 08:39:01 +0000] information/IcingaDB: 'icingadb' started.
[2021-01-19 08:39:02 +0000] information/ConfigItem: Activated all objects.
[2021-01-19 08:39:38 +0000] information/IcingaDB: Initial config/status dump finished in 21.6606 seconds.

@julianbrost julianbrost added bug Something isn't working area/icingadb New backend labels Jan 19, 2021
@icinga-probot icinga-probot bot added this to the 2.13.0 milestone Jan 19, 2021
This commit sets the activation priority if IcingaDB objects to 100 (the
same value as IDO uses) so that it get's activated after most regular
config objects (hosts, services, ...).

Before (note how Icinga 2 continues to active objects for over a minute
after IcingaDB is started and thinks the initial dump is done):

    [2021-01-19 08:33:19 +0000] information/IcingaDB: 'icingadb' started.
    [2021-01-19 08:34:02 +0000] information/IcingaDB: Initial config/status dump finished in 28.247 seconds.
    [2021-01-19 08:35:49 +0000] information/ConfigItem: Activated all objects.

After (now activation of objects is done right after IcingaDB is
started, as it's one of the last objects to be activated):

    [2021-01-19 08:39:01 +0000] information/IcingaDB: 'icingadb' started.
    [2021-01-19 08:39:02 +0000] information/ConfigItem: Activated all objects.
    [2021-01-19 08:39:38 +0000] information/IcingaDB: Initial config/status dump finished in 21.6606 seconds.
@julianbrost julianbrost force-pushed the bugfix/icingadb-activation-priority branch from 0bf11c3 to 509db4a Compare January 19, 2021 08:46
Copy link
Member

@lippserd lippserd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Al2Klimov Al2Klimov merged commit ca52366 into master Jan 28, 2021
@icinga-probot icinga-probot bot deleted the bugfix/icingadb-activation-priority branch January 28, 2021 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/icingadb New backend bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants