IcingaDB: Check whether or not cr is nullptr #8599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icinga-probot
bot
added
area/icingadb
Al2Klimov
approved these changes
Jan 18, 2021
julianbrost
reviewed
Jan 18, 2021
| @@ -1324,7 +1324,7 @@ void IcingaDB::SendSentNotification( | |||
| "notification_id", GetObjectIdentifier(notification), | |||
| "host_id", GetObjectIdentifier(host), | |||
| "type", Convert::ToString(type), | |||
| "state", Convert::ToString(service ? Convert::ToLong(cr->GetState()) : Convert::ToLong(Host::CalculateState(cr->GetState()))), | |||
| "state", Convert::ToString(cr ? service ? Convert::ToLong(cr->GetState()) : Convert::ToLong(Host::CalculateState(cr->GetState())) : 99), | |||
There was a problem hiding this comment.
I've already seen this magic 99 appear elsewhere in the code. Is there really no constant for this?
There was a problem hiding this comment.
Exactly. (If it already appears multiple times, I consider it another construction area.)
julianbrost
approved these changes
Jan 18, 2021
icinga-probot
bot
deleted the
bugfux/check-if-cr-is-not-nullptr-while-writing-history-8592
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #8592