Skip to content

Prepare Windows build scripts for builds with Visual Studio 2019 #8390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 21, 2020

Conversation

julianbrost
Copy link
Contributor

@julianbrost julianbrost commented Oct 21, 2020

$env:CMAKE_GENERATOR_PLATFORM is only used in configure-dev.ps1 but now is also required in configure.ps1 to allow the build pipeline to be upgraded to Visual Studio 2019.

Note: Merge together with https://git.icinga.com/packaging/windows-icinga2/-/merge_requests/3

@icinga-probot icinga-probot bot added this to the 2.13.0 milestone Oct 21, 2020
@julianbrost julianbrost mentioned this pull request Oct 21, 2020
10 tasks
@julianbrost julianbrost force-pushed the feature/vs2019-jbrost branch from 05c156f to f59e514 Compare October 21, 2020 08:42
$env:CMAKE_GENERATOR_PLATFORM is only used in configure-dev.ps1 but now
is also required in configure.ps1 to allow the build pipeline to be
upgraded to Visual Studio 2019.

Additionally bump the versions in paths for Boost and OpenSSL.
@julianbrost julianbrost force-pushed the feature/vs2019-jbrost branch from 3db4937 to 025d38b Compare October 21, 2020 09:15
@julianbrost julianbrost marked this pull request as draft October 21, 2020 09:16
@julianbrost julianbrost marked this pull request as ready for review October 21, 2020 09:40
@Al2Klimov Al2Klimov merged commit 327377a into master Oct 21, 2020
@icinga-probot icinga-probot bot deleted the feature/vs2019-jbrost branch October 21, 2020 10:09
julianbrost added a commit that referenced this pull request Oct 21, 2020
PR #8390 changed the default version of Visual Studio to 2019 because
PR #8373 introduces behavior that is incompatible with MSVC versions
shipped with older versions of Visual Studio.
julianbrost added a commit that referenced this pull request Oct 21, 2020
PR #8390 changed the default version of Visual Studio to 2019 because
PR #8373 introduces behavior that is incompatible with MSVC versions
shipped with older versions of Visual Studio.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants