Skip to content

PerfdataValue: add UoMs #7871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 14, 2020
Merged

PerfdataValue: add UoMs #7871

merged 2 commits into from
Dec 14, 2020

Conversation

Al2Klimov
Copy link
Member

@Al2Klimov Al2Klimov commented Feb 28, 2020 •
edited
Loading 

* {,{K,M,G,T,P,E,Z,Y}{,i}}B
  => bytes
* {,{k,m,g,t,p,e,z,y}{,i}}b
  => bits
* packets
* {n,u,m,}s m h d
  => seconds
* {n,u,m,,k,M,G,T,P,E,Z,Y}{{A,O,V,W},{A,W}{s,m,h}}
  => amperes, ohms, volts, watts, ampere-seconds, watt-hours
* lm dBm
  => lumens decibel-milliwatts
* {n,u,m,,k}g t
  => grams
* C F K
  => degrees-celsius, degrees-farenheit, degrees-kelvin
* {m,,h}l
  => liters

fixes #7225
closes #6868

@Al2Klimov Al2Klimov added this to the 2.13.0 milestone Feb 28, 2020
@Al2Klimov Al2Klimov self-assigned this Feb 28, 2020
@Al2Klimov Al2Klimov force-pushed the feature/more-uoms-for-perfdata-7225 branch 2 times, most recently from e2c9cb4 to 8bc92a9 Compare March 24, 2020 15:55
@Al2Klimov
Copy link
Member Author

@N-o-X Please have a look whether that set of units is OK for you.

@Al2Klimov Al2Klimov added the needs feedback We'll only proceed once we hear from you again label Mar 24, 2020
@Al2Klimov Al2Klimov force-pushed the feature/more-uoms-for-perfdata-7225 branch 4 times, most recently from 35e1bc1 to 92d8c31 Compare March 25, 2020 11:42
@Al2Klimov Al2Klimov force-pushed the feature/more-uoms-for-perfdata-7225 branch 2 times, most recently from d718bf7 to 717dc8e Compare March 25, 2020 12:29
@Al2Klimov Al2Klimov changed the title WIP PerfdataValue: add UoMs Mar 25, 2020
@Al2Klimov
Copy link
Member Author

FYI @lippserd @LordHepipud @Thomas-Gelf

@Al2Klimov Al2Klimov force-pushed the feature/more-uoms-for-perfdata-7225 branch from 717dc8e to 7088d51 Compare March 25, 2020 12:50
N-o-X
N-o-X reviewed Mar 25, 2020
View reviewed changes
@Al2Klimov Al2Klimov force-pushed the feature/more-uoms-for-perfdata-7225 branch 3 times, most recently from c479471 to b844ab2 Compare March 25, 2020 17:47
@Al2Klimov Al2Klimov removed the needs feedback We'll only proceed once we hear from you again label Mar 25, 2020
@Al2Klimov Al2Klimov requested a review from N-o-X March 25, 2020 17:48
@Al2Klimov Al2Klimov removed their assignment Mar 25, 2020
@Al2Klimov Al2Klimov marked this pull request as ready for review March 26, 2020 16:09
N-o-X
N-o-X approved these changes Apr 2, 2020
View reviewed changes
Copy link
Contributor

@N-o-X N-o-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Al2Klimov Al2Klimov self-assigned this Apr 2, 2020
@Al2Klimov Al2Klimov force-pushed the feature/more-uoms-for-perfdata-7225 branch from b844ab2 to f318430 Compare April 2, 2020 09:16
@Al2Klimov Al2Klimov removed their assignment Apr 2, 2020
@Al2Klimov Al2Klimov requested a review from N-o-X April 2, 2020 09:18
N-o-X
N-o-X suggested changes Apr 3, 2020
View reviewed changes
@Al2Klimov Al2Klimov self-assigned this Apr 3, 2020
@Al2Klimov
PerfdataValue: add UoMs
720a88c 
* {,{K,M,G,T,P,E,Z,Y}{,i}}B
  => bytes
* {,{k,m,g,t,p,e,z,y}{,i}}b
  => bits
* packets
* {n,u,m,}s m h d
  => seconds
* {n,u,m,,k,M,G,T,P,E,Z,Y}{{A,O,V,W},{A,W}{s,m,h}}
  => amperes, ohms, volts, watts, ampere-seconds, watt-hours
* lm dBm
  => lumens decibel-milliwatts
* {n,u,m,,k}g t
  => grams
* C F K
  => degrees-celsius, degrees-fahrenheit, degrees-kelvin
* {m,,h}l
  => liters

refs #7225
@Al2Klimov Al2Klimov force-pushed the feature/more-uoms-for-perfdata-7225 branch from f318430 to 720a88c Compare April 3, 2020 10:47
@Al2Klimov Al2Klimov removed their assignment Apr 3, 2020
@Al2Klimov Al2Klimov requested a review from N-o-X April 3, 2020 10:47
@Al2Klimov Al2Klimov added area/checks Check execution and results enhancement New feature or request labels Dec 14, 2020
@Al2Klimov Al2Klimov merged commit 6b04ef6 into master Dec 14, 2020
@icinga-probot icinga-probot bot deleted the feature/more-uoms-for-perfdata-7225 branch December 14, 2020 17:43
@Al2Klimov Al2Klimov mentioned this pull request Feb 4, 2021
Closed
This was referenced Jun 7, 2021
Merged
Merged
This was referenced Sep 10, 2021
Closed
Closed
@julianbrost julianbrost mentioned this pull request Nov 19, 2021
Closed
@martialblog martialblog mentioned this pull request Apr 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@N-o-X N-o-X N-o-X approved these changes

Assignees
No one assigned
Labels
area/checks Check execution and results enhancement New feature or request
Projects
None yet
Milestone
2.13.0
Development

Successfully merging this pull request may close these issues.

Allow more UoMs for perfdata
2 participants
@Al2Klimov @N-o-X