Skip to content

Remove clear variable from disk CheckCommand #10531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 19, 2025
Merged

Remove clear variable from disk CheckCommand #10531

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3c73b4
Remove clear variable from disk CheckCommand
RincewindsHat Aug 6, 2025
9c54b6c
Remove -C (disk_clear) argument completely, only leave a comment
RincewindsHat Aug 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion doc/10-icinga-template-library.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,7 +414,6 @@ disk\_partition | **Optional.** The partition. **Deprecated in 2.3.**
disk\_partition\_excluded | **Optional.** The excluded partition. **Deprecated in 2.3.**
disk\_partitions | **Optional.** The partition(s). Multiple partitions must be defined as array.
disk\_partitions\_excluded | **Optional.** The excluded partition(s). Multiple partitions must be defined as array.
disk\_clear | **Optional.** Clear thresholds. May be true or false.
disk\_exact\_match | **Optional.** For paths or partitions specified with -p, only check for exact paths. May be true or false.
disk\_errors\_only | **Optional.** Display only devices/mountpoints with errors. May be true or false.
disk\_ignore\_reserved | **Optional.** If set, account root-reserved blocks are not accounted for freespace in perfdata. May be true or false.
Expand Down
7 changes: 3 additions & 4 deletions itl/command-plugins.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1636,6 +1636,9 @@ object CheckCommand "disk" {
command = [ PluginDir + "/check_disk" ]

arguments = {
/*
"-C" (disk_clear) is missing on purpose, since there is no useful use case possible the way check_disk is mapped here
*/
"--extra-opts" = {
value = "$disk_extra_opts$"
description = "Read extra plugin options from an ini file."
Expand Down Expand Up @@ -1689,10 +1692,6 @@ object CheckCommand "disk" {
key = "-x"
value = "$disk_partition_excluded$"
}
"-C" = {
set_if = "$disk_clear$"
description = "Clear thresholds"
}
"-E" = {
set_if = "$disk_exact_match$"
description = "For paths or partitions specified with -p, only check for exact paths"
Expand Down
Loading