IcingaDB::TimestampToMilliseconds(): limit output to four year digits #10059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianbrost
requested changes
Aug 20, 2024
Al2Klimov
changed the title
Al2Klimov
force-pushed
the
IcingaDB-TimestampToMilliseconds-limit
branch
from
8c05158 to
a2caaf4
Compare
Al2Klimov
force-pushed
the
IcingaDB-TimestampToMilliseconds-limit
branch
from
a2caaf4 to
d93f955
Compare
yhabteab
reviewed
Sep 6, 2024
Al2Klimov
force-pushed
the
IcingaDB-TimestampToMilliseconds-limit
branch
from
d93f955 to
9e2d6aa
Compare
julianbrost
requested changes
Sep 26, 2024
Al2Klimov
force-pushed
the
IcingaDB-TimestampToMilliseconds-limit
branch
from
9e2d6aa to
c436e8d
Compare
julianbrost
requested changes
Sep 30, 2024
Al2Klimov
force-pushed
the
IcingaDB-TimestampToMilliseconds-limit
branch
from
c436e8d to
d51ae84
Compare
julianbrost
reviewed
Sep 30, 2024
Too high timestamps may overflow uint64_t (and the YYYY format) and negative ones don't fit into uint64_t. Those may crash our Go daemon.
Al2Klimov
force-pushed
the
IcingaDB-TimestampToMilliseconds-limit
branch
from
d51ae84 to
dc4869c
Compare
julianbrost
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Too high timestamps may overflow uint64_t (and the YYYY format) and negative ones don't fit into uint64_t. Those may crash our Go daemon.