composer.json: Remove config.platform.php #9
Conversation
|
@nilmerg If I remember correctly we hardcode the PHP version to a common minimum so releases have deps installed that are guaranteed to work. This should be PHP 7.0 for the moment right? We could add |
|
I'm not sure if I can befriend the idea that the environment controls which minimum version we require 🤔 That's part of composer.json just like which versions of the libs should be installed in the given set. And that's not incorrect currently, only in the snapshot it might be wrong, but even that built fine in the latest runs. The problem is entirely on your side, since you have a custom build process. Just like the snapshots have here, and so the fix I see is only part of |
|
Sure, my fix is to override that platform config as it is just wrong since we dropped PHP 5.6 support. Platform is not about the version we support but the version composer installs the dependencies for. So I can't install newer IPL libs since they all require PHP >= 7. I'm also fine with hardcoding it in composer.json, but then it must be 7.0. Edit: What I'm saying is that this repo is missing the "Drop PHP 5.6 support" completely. |
That is true, once composer.json requires a version that really drops it. As it stands, it does not do that. Nor does any released version of the ipl repositories. |
I understand. You don't want to increase the platform version yet. |
|
I also meant the fix I see is only part of bin/make-snapshot.sh. You're correct with your proposal, it's just not the correct location yet. Snapshots also override the library versions and force the install of the master everywhere, there the minimum required PHP version really might change and should probably be overridden. 🤷♂️ |
2 participants
Composer update will fail if a dependency requires a newer PHP version than the hardcoded one.
refs lippserd/docker-compose-icinga#23