Improve the ScheduleForm #294
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukhwinder33445
force-pushed
the
improve-schedule-form
branch
from
2953bec to
b17824b
Compare
sukhwinder33445
changed the title
nilmerg
requested changes
Apr 3, 2025
application/forms/ScheduleForm.php
Outdated
| $this->addElement('text', 'name', [ | ||
| 'required' => true, | ||
| 'label' => $this->translate('Name') | ||
| 'label' => $this->translate('Schedule Name'), | ||
| 'placeholder' => 'e.g. working hours, on call, etc ...' |
public/css/form.less
Outdated
| @@ -116,3 +116,8 @@ | |||
| border-color: transparent; | |||
| } | |||
| } | |||
|
|
|||
| .icinga-form p.description { | |||
There was a problem hiding this comment.
.icinga-form is used for layout, this is style. For style a tag is usually not important, just a class suffices.
Suggested change
| .icinga-form p.description { | |
| .icinga-controls .description { |
| new Text($this->translate( | ||
| 'Organize contacts and contact groups in a time based schedule and let them rotate' | ||
| . ' automatically. Multiple rotations can be added to your schedule to represent the rotating' | ||
| . ' members in your admin team. Schedules can be used as recipients of event rules.' |
There was a problem hiding this comment.
This poses another question for me 🤣 : What is an admin team?
I think a less specific but still not too abstract example is required, to explain why multiple rotations are useful.
Something along this line:
Multiple rotations allow differing rotation patterns to override others.
But not quite this line, I just cannot come up with a better alternative right now. But I hope you get the idea.
sukhwinder33445
force-pushed
the
improve-schedule-form
branch
from
b17824b to
143e2f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #275