This repository has been archived by the owner on Nov 6, 2024. It is now read-only.
Feature: add socket_path to icinga2_idopgsqlconnection
and icinga2_idomysqlconnection
custom resources
#324
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
With the existing
icinga2_idopgsqlconnection
andicinga2_idomysqlconnection
custom resources, you are unable to set thesocket_path
option in the object.While I was using the chef-icingaweb2 cookbook, it does not set
socket_path
, so it defaults to/var/lib/mysql/mysql.sock
whenhost
is set tolocalhost
.Justification
Users may need to specify where there socket is located if they don't want to open up permissions to
/var/lib/mysql
or they have a non-standard socket path.Solution
Add the
socket_path
variable to bothicinga2_idopgsqlconnection
andicinga2_idomysqlconnection
custom resources and their templates.I didn't see any specific testing in place for the custom resource, so please let me know if I need to add a test or two.