Skip to content
This repository has been archived by the owner on Nov 6, 2024. It is now read-only.

Feature: add socket_path to icinga2_idopgsqlconnection and icinga2_idomysqlconnection custom resources #324

Merged

Conversation

taylorsmcclure
Copy link

Problem

With the existing icinga2_idopgsqlconnection and icinga2_idomysqlconnection custom resources, you are unable to set the socket_path option in the object.

While I was using the chef-icingaweb2 cookbook, it does not set socket_path, so it defaults to /var/lib/mysql/mysql.sock when host is set to localhost.

Justification

Users may need to specify where there socket is located if they don't want to open up permissions to /var/lib/mysql or they have a non-standard socket path.

Solution

Add the socket_path variable to both icinga2_idopgsqlconnection and icinga2_idomysqlconnection custom resources and their templates.

I didn't see any specific testing in place for the custom resource, so please let me know if I need to add a test or two.

@vkhatri vkhatri merged commit bd21a53 into Icinga:master Aug 14, 2018
@vkhatri
Copy link
Member

vkhatri commented Aug 14, 2018

@taylorsmcclure 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants