Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add role Icinga Web 2 #161

Merged
merged 40 commits into from
Jul 5, 2023
Merged

Add role Icinga Web 2 #161

merged 40 commits into from
Jul 5, 2023

Conversation

mkayontour
Copy link
Member

This PR will introduce the feature to configure, manage Icinga Web 2 and its modules. It allows for the following features:

  • Manage Resources.ini
  • Manage authentication.ini
  • Manage config.ini
  • Manage Groups.ini
  • Import DB Schema
  • Create Admin Users and Permissions
  • Manage Module Monitoring
  • Manage Module IcingaDB
  • Manage Module Director, Import Schema and run Kickstart

Currently tested OSs

  • Ubuntu 22.04.2 LTS

Future Plans:

  • Add installation routine for modules from source/git.
  • Add more modules like Businessprocess/graphite/cube etc.
  • Add a generic module installation with or without configuration for community modules?

Ref: #31

mkayontour and others added 26 commits May 5, 2023 16:50
@mkayontour
added local/vagrant/vbox test scenario
6fa72fd
@mkayontour
added icingaweb2 role first layout
53e18ec
@mkayontour
changed task names
536db03
@mkayontour
added pgsql setup tasks
cde9cfe
@mkayontour
remove wrong ternary function
c2c5dd7
@mkayontour
remove icingaweb2_db defaults
f1501d1
@mkayontour
add director module support
2bbabb7
@mkayontour
add list support for ini options
cb1f9fe
@mkayontour
add tests for icingaweb2_roles dictionary
90e7b95
@mkayontour
add list handling for ini values
89ce408
@mkayontour
fix lint syntax
56bf748
@mkayontour
deactivate icinga2 test config
d29e436
@mkayontour
remove default packages from defaults
f5db2ab
@mkayontour
add permissions for config dir
a422b7d
@mocdaniel
Adds IcingaDB-Web support (#159)
e9222e2 
* Adds IcingaDB-Web support

* Adjusts task names to conform with fqcn names

* Fixes error with importing DB schema twice in HA setups

* Renames 'icingadb_web' to 'icingadb' everywhere

* Enhances handling of Icingaweb2 modules
@mkayontour
remove enable module to seperate enabling and configuration
b3c93a6
@mkayontour
provide generic module configuration
b49ad78
@mkayontour
use generic module config in monitoring
85c0253
@mkayontour
change icingadb web module package
72d9c09
@mkayontour
rename to generic module
742a6a9
@mkayontour
use generic module config generation
3542064
@mkayontour
add module director
8a54cb4
@mkayontour
add module names to task for readability
164c1d7
@mkayontour
update local-default molecule testing
f77d7d4
@mkayontour
add documentation
7fea93b
@mkayontour
change module name in default example
1a5828d
@mkayontour mkayontour added the feature New feature or request label Jul 4, 2023
@mkayontour mkayontour requested a review from mocdaniel July 4, 2023 14:45
@mkayontour mkayontour self-assigned this Jul 4, 2023
@cla-bot cla-bot bot added the cla/signed label Jul 4, 2023
mocdaniel
mocdaniel requested changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@mocdaniel mocdaniel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest we fix the obvious things I found and discuss whether we want to act on all the additional check failures reported by our pipelines? (missing file permissions and literal comparisons to True/False, mainly).

roles/icingaweb2/tasks/manage_icingaweb_config.yml Outdated Show resolved Hide resolved
roles/icingaweb2/tasks/manage_icingaweb_mysql_db.yml Outdated Show resolved Hide resolved
roles/icingaweb2/tasks/manage_icingaweb_mysql_db.yml Outdated Show resolved Hide resolved
roles/icingaweb2/tasks/manage_icingaweb_pgsql_db.yml Outdated Show resolved Hide resolved
roles/icingaweb2/tasks/modules/monitoring.yml Outdated Show resolved Hide resolved
mkayontour and others added 11 commits July 5, 2023 13:40
@mkayontour @mocdaniel
change name of task
5762829 
Co-authored-by: Daniel Bodky <dbodky@gmail.com>
@mkayontour @mocdaniel
delete unused commentary
62d86d2 
Co-authored-by: Daniel Bodky <dbodky@gmail.com>
@mkayontour @mocdaniel
fix linter spacing issue
c7153ac 
Co-authored-by: Daniel Bodky <dbodky@gmail.com>
@mkayontour @mocdaniel
fix linter spacing issue
e96b7f2 
Co-authored-by: Daniel Bodky <dbodky@gmail.com>
@mkayontour @mocdaniel
remove unused comments
a520b25 
Co-authored-by: Daniel Bodky <dbodky@gmail.com>
@mkayontour
remove unsupported python2 tests
604619d
@mkayontour
add docu and remove examples
5dead8f
@mkayontour
update build to supported ansible versions
547a925
@mkayontour
update build requirements
36e42cf
@mkayontour
renamed requirements file
4049d51
@mkayontour
removed least suppported python version
97a56f6
@mkayontour
Copy link
Member Author

Updated the Build, all the linter issues can be worked on later.

@mocdaniel
Copy link
Contributor

LGTM, if we fix the linter issues separately.

@mkayontour mkayontour merged commit 4077df4 into main Jul 5, 2023
@mocdaniel mocdaniel deleted the feature/31-add-role-to-manage-icingaweb2 branch July 6, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mocdaniel mocdaniel mocdaniel approved these changes

Assignees

@mkayontour mkayontour

Labels
cla/signed feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkayontour @mocdaniel