Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

request.go: add Extra1/Extra2 to get the extra field for CQE32 flag. #25

Merged
merged 1 commit into from
Apr 3, 2023

Conversation

sungup
Copy link
Contributor

@sungup sungup commented Mar 28, 2023

for the extra return value from pass-through command, add extra field to Request and CompletionQueueEvent and its structures. Different from the res, r0, and r1 field, these extra field should be managed by their pass-through device's specification. So, just pass the extra field from CQE to iouring-go's application.

for the extra return value from pass-through command, add extra field
to Request and CompletionQueueEvent and its structures. Different from
the res, r0, and r1 field, these extra field should be managed by their
pass-through device's specification. So, just pass the extra field from
CQE to iouring-go's application.

Signed-off-by: Sungup Moon <sungup@me.com>
Copy link
Owner

@Iceber Iceber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for your contribution!

@Iceber Iceber merged commit 002cfd2 into Iceber:main Apr 3, 2023
@sungup sungup deleted the add_extrafield_in_cqe branch April 3, 2023 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants