Replace satori/go.uuid with google/uuid #1573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`github.com/satori/go.uuid` is no longer being actively maintained. So we should just use the newer `github.com/google/uuid`. Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1573 +/- ##
=====================================
Coverage 2.97% 2.97%
=====================================
Files 39 39
Lines 4433 4433
=====================================
Hits 132 132
Misses 4289 4289
Partials 12 12 ☔ View full report in Codecov by Sentry. |
|
at some point we should refactor the code to ensure code coverage doesn't drop. merging PR with failing checks is a starting point of "broken windows" - https://medium.com/@learnstuff.io/broken-window-theory-in-software-development-bef627a1ce99 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
github.com/satori/go.uuidis no longer being actively maintained (last commit was 5 years ago 1). So we should just use the newergithub.com/google/uuid.Footnotes
https://github.com/satori/go.uuid/commits/master/ ↩