This repository has been archived by the owner on Jul 27, 2020. It is now read-only.
Cleaned up code, fix a couple bugs #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will test this soon. Thanks |
|
Finally got a chance to test this today. Cleans up the code a lot, thank you. |
IanLunn
added a commit
that referenced
this pull request
Jun 11, 2012
Cleaned up code, fix a couple bugs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've cleaned up the JavaScript to make the parallax scrolling a bit better. I needed to dive into the code in order to fix a bug with a site I'm working on that uses "background-scale: contain", where the image would bounce around after the user scrolled.
Let me know, please, if this meets your coding standards.