Changed "Bounce in" to "Bounce out" and viceversa on master branch, they were inverted. #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swapped their names because they were inverted, "Bounce in" bounced out and viceversa, I changed them to make the animation correspond to the class name.
Swapped their names because they were inverted, "Bounce in" bounced out and viceversa, I changed them to make the animation correspond to the class name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I love your library, I've used it for my projects and I wanted to contribute since I noticed that on the demo site http://ianlunn.github.io/Hover/ and on the source files, "Bounce in" and "Bounce out" effects are inverted. "Bounce in" bounces out and "Bound out" bounces in. I made these changes to the source file and to the minified file as well, on the master branch and made a pull request for the gh-pages branch with the same changes.