optimizing the game Loop Moving the all components into the Game Clas…

…s ( FPS counter )
IamRishavDas · Feb 19, 2024 · 87a73b0 · 87a73b0
1 parent a6bea51
commit 87a73b0
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 18 deletions.
diff --git a/NewGame/Game.java b/NewGame/Game.java
@@ -1,6 +1,6 @@
 package NewGame;
 
-public class Game implements Runnable{
+public class Game implements Runnable {
     private GameFrame gameFrame;
     private GamePanel gamePanel;
 
@@ -15,20 +15,31 @@ public Game() {
         startGameLoop();
     }
 
-    private void startGameLoop(){
+    private void startGameLoop() {
         gameThread = new Thread(this);
         gameThread.start();
     }
 
-    public void run(){
+    public void run() {
         double timePerFrame = 1000000000.0 / FPS;
         long lastFrame = System.nanoTime();
         long now = System.nanoTime();
+
+        int frames = 0;
+        long lastCheck = System.currentTimeMillis();
+
         while (true) {
             now = System.nanoTime();
-            if(now - lastFrame > timePerFrame){
+            if (now - lastFrame > timePerFrame) {
                 gamePanel.repaint();
                 lastFrame = now;
+                frames++;
+            }
+
+            if ((System.currentTimeMillis() - lastCheck) >= 1000) {
+                lastCheck = System.currentTimeMillis();
+                System.out.println("FPS: " + frames);
+                frames = 0;
             }
         }
     }

diff --git a/NewGame/GamePanel.java b/NewGame/GamePanel.java
@@ -15,12 +15,8 @@ public class GamePanel extends JPanel {
 
     // controlling speed
     private float dirX = 3f;
-    private float dirY = 3f;;
-
-    // fps counter
-    private int frames = 0;
-    private long lastCheck = 0;
-
+    private float dirY = 3f;
+
     //ball color
     private Color color = new Color(24,255,254);
 
@@ -50,14 +46,7 @@ public void paintComponent(Graphics g) {
 
         g.setColor(color);
         g.fillOval((int)posX, (int)posY, 100, 100);
-        updateOval();
-
-        frames++;
-        if ((System.currentTimeMillis() - lastCheck) >= 1000) {
-            lastCheck = System.currentTimeMillis();
-            System.out.println("FPS: " + frames);
-            frames = 0;
-        }
+        updateOval();      
     }
 
     private void updateOval() {