Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update korean, japanese language. #65

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

Yorunokyujitsu
Copy link
Contributor

Add "Removed " string to all languages.
Korean and Japanese translation updates.

@ITotalJustice ITotalJustice merged commit 87642e9 into ITotalJustice:master Dec 31, 2024
1 check passed
@Yorunokyujitsu
Copy link
Contributor Author

gfx::drawTextArgs(vg, x + w - text_xoffset, y + (h / 2.f), 16.f, NVG_ALIGN_RIGHT | NVG_ALIGN_MIDDLE, theme->elements[text_id].colour, "version: %s", e.tag.c_str());

    gfx::drawTextArgs(vg, x + w - text_xoffset, y + (h / 2.f), 16.f, NVG_ALIGN_RIGHT | NVG_ALIGN_MIDDLE, theme->elements[text_id].colour, "version: %s"_i18n.c_str(), e.tag.c_str());

I'm sorry to bother you.
If possible, could you apply it to the next commit?

@ITotalJustice
Copy link
Owner

gfx::drawTextArgs(vg, x + w - text_xoffset, y + (h / 2.f), 16.f, NVG_ALIGN_RIGHT | NVG_ALIGN_MIDDLE, theme->elements[text_id].colour, "version: %s", e.tag.c_str());

    gfx::drawTextArgs(vg, x + w - text_xoffset, y + (h / 2.f), 16.f, NVG_ALIGN_RIGHT | NVG_ALIGN_MIDDLE, theme->elements[text_id].colour, "version: %s"_i18n.c_str(), e.tag.c_str());

I'm sorry to bother you. If possible, could you apply it to the next commit?

Sure, but I'm not 100% on keeping it named version, or instead name it tag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants