Define complextype
, realtype
, imagtype
#52
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define type space versions of
Base.complex
,Base.real
, andBase.imag
, analogous to #51 which definessimilartype
as a type space version ofBase.similar
.The motivation for this is making block sparse matrix SVD more generic, specifically this helps generalize these lines: https://github.com/ITensor/BlockSparseArrays.jl/blob/f9b971b7aafb2cdaf828160863da87676ba07f0f/src/factorizations/svd.jl#L27-L30 where we construct the block type of the matrix of singular values. (This is one approach to that, another approach could be to infer the block types of U, S, and V by calling
Base.promote_op(svd_compact, blocktype(A))
, I'll play around with both approaches but even if this PR isn't used for that particular case I think it is still useful.)