-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ITensors] Excise ITensors.ITensorMPS #1551
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtfishman
commented
Oct 22, 2024
10 tasks
This will be the PR after which one must put |
Yes. |
mtfishman
commented
Oct 23, 2024
test/base/utils/TestITensorsExportedNames/TestITensorsExportedNames.jl
Outdated
Show resolved
Hide resolved
This was referenced Oct 23, 2024
This was referenced Oct 24, 2024
mtfishman
changed the title
[WIP] [ITensors] Excise ITensors.ITensorMPS
[ITensors] Excise ITensors.ITensorMPS
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
ITensors.ITensorMPS
module and move it toITensorMPS.jl
.See also ITensor/ITensorMPS.jl#31.
To-do:
ITensors
dependency from tests #1553.)siteinds
,OpSum
,op
,OpName
,state
, etc. being removed from the exports of ITensors.jl and instead users should load ITensorMPS.jl if they want access to them.Project.toml
(maybe check with Aqua.jl).to_nameddimsarray(x::AbstractMPS)
inITensorMPS.jl
.MoveEDIT: I'd like to use MultiDocumenter.jl eventually but for now I just used: How to include the docstring for a function from another package in my Julia docs? JuliaDocs/Documenter.jl#1734.ITensors.ITensorMPS
docs over to ITensorMPS.jl` and aggregate documentation with MultiDocumenter.jl.ITensors.ITensorMPS
that are being removed.dot
andinner
.ITensors.SiteTypes
.