- 
                Notifications
    You must be signed in to change notification settings 
- Fork 2
          Working contract_network
          #7
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Codecov Report❌ Patch coverage is  
 Additional details and impacted files@@            Coverage Diff             @@
##             main       #7      +/-   ##
==========================================
+ Coverage   54.13%   56.51%   +2.37%     
==========================================
  Files           4        6       +2     
  Lines         447      476      +29     
==========================================
+ Hits          242      269      +27     
- Misses        205      207       +2     
 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
 | 
| Your PR no longer requires formatting changes. Thank you for your contribution! | 
for more information, see https://pre-commit.ci
| @mtfishman I'm not really sure what the failing test is to do with... something coming from  | 
| 
 It looks like moving the TensorOperations code to a package extension made it so that ITensorBase is no longer a direct dependency of ITensorNetworksNext, since now it is only used in that package extension (Aqua is rightly detecting that situation and seeing that there is a dependency listed in the Project.toml that isn't being used in the main package). However, in this case I think we should try to use NamedDimsArrays directly rather than ITensorBase, I can give you pointers on how to do that. | 
Co-authored-by: Matt Fishman <mtfishman@users.noreply.github.com>
Co-authored-by: Matt Fishman <mtfishman@users.noreply.github.com>
Co-authored-by: Matt Fishman <mtfishman@users.noreply.github.com>
Co-authored-by: Matt Fishman <mtfishman@users.noreply.github.com>
| Could you also bump the package version? | 
| Also thinking about it more, I'd slightly prefer the name  | 
| Makes sense. I'll make that change. | 
| I think this looks good for now, thanks for sticking with all the comments. I think there are a few follow-ups to this: 
 But this seems like a good enough start to build other algorithms like BP so I'll merge this and we can work on those things as next steps. | 
This PR introduces the ability to contract vectors of
AbstractArraysand thusAbstractTensorNetworks via thecontractnetwork(tn; sequence)function.The
sequenceis used to tell thecontraction_sequencebackend how to find the desired sequence, with the stringssequence= "leftassociative" and "optimal"supported (the latter viaTensorOperations) alongside support for sending a specific pre-defined sequence.Rudimentary tests are included, although we might want to consider making these more robust and also testing the sequence finding functionality ourselves.