Skip to content

IndsNetwork additions #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 4, 2022
Merged

Conversation

leburgel
Copy link
Contributor

@leburgel leburgel commented Oct 4, 2022

Some changes and additions for IndsNetworks:

  • Defined is_directed for AbstractIndsNetwork subtypes so they work with Graphs.SimpleTraits
  • Added a uniqueinds method similar to the one for AbstractITensorNetwork.
  • Added a merge method for merging AbstractIndsNetworks, which just corresponds to a set union of all site and link indices of the network. Proved quite useful for me, though naming and usefulness in general might be debatable.
  • Extended the IndsNetwork constructor to allow specifying the indices for every site/link of the network individually by means of a Dictionary, as well as specifying multiple indices per site/link.
  • Extended the siteind system for IndsNetworks to allow passing either an Integer, String or Function sitetype, as well as specifying the sitetype for every site individually. Now also allows passing any Graphs.AbstractGraph subtype, solving Allow passing a Graphs.SimpleGraph to siteinds #7.
  • Reorganized tests to use separate files.

@mtfishman
Copy link
Member

Thanks @leburgel, this looks good to me. It looks like there are some merge conflicts caused by #13 but once those are fixed I'll merge this.

Gotta get the tests working on this package, it's tough to figure out what's going on when dealing with unregistered packages...

@leburgel
Copy link
Contributor Author

leburgel commented Nov 3, 2022

Conflicts are resolved and tests pass locally, no idea how to fix the actual CI though.

@mtfishman
Copy link
Member

In #13 I deleted the file examples/peps/utils.jl since I moved it all into the library, but it looks like you added it back during your merge.

@mtfishman
Copy link
Member

(I think I'll just have to bite the bullet and register all of the dependent packages to get CI working better.)

@leburgel
Copy link
Contributor Author

leburgel commented Nov 3, 2022

In #13 I deleted the file examples/peps/utils.jl since I moved it all into the library, but it looks like you added it back during your merge.

My bad, removed it again.

@mtfishman
Copy link
Member

Thanks again for the contribution!

@mtfishman mtfishman merged commit e8918a1 into ITensor:main Nov 4, 2022
@leburgel leburgel deleted the indsnetwork_additions branch November 4, 2022 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants