Skip to content

Introduce binary_tree_structure, path_graph_structure, and rename binary_tree_partition #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 24, 2023

Conversation

LinjianMa
Copy link
Contributor

@LinjianMa LinjianMa commented Feb 19, 2023

Introduce APIs below as is discussed in #66:

"""
Outputs a maximimally unbalanced directed binary tree DataGraph defining the desired graph structure
"""
function path_graph_structure(tn::ITensorNetwork)
end

"""
Outputs a directed binary tree DataGraph defining the desired graph structure
"""
function binary_tree_structure(tn::ITensorNetwork)
end

function partition(
  ::Algorithm"mincut_recursive_bisection", tn::ITensorNetwork, inds_btree::DataGraph
)

function partition(tn::ITensorNetwork, inds_btree::DataGraph; alg::String)
  return partition(Algorithm(alg), tn, inds_btree)
end

@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2023

Codecov Report

Merging #69 (7978e6b) into main (d197854) will increase coverage by 0.32%.
The diff coverage is 93.65%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
+ Coverage   75.83%   76.16%   +0.32%     
==========================================
  Files          56       56              
  Lines        2918     2970      +52     
==========================================
+ Hits         2213     2262      +49     
- Misses        705      708       +3     
Impacted Files Coverage Δ
src/mincut.jl 94.44% <90.32%> (-0.43%) ⬇️
src/binary_tree_partition.jl 98.23% <96.87%> (-0.64%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mtfishman
Copy link
Member

Over all this looks good, glad to see that changing the data structure didn't change much and I like the path_graph_structure and binary_tree_structure interface.

@mtfishman mtfishman merged commit d9f178b into ITensor:main Feb 24, 2023
@LinjianMa LinjianMa deleted the refactor branch July 1, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants