Skip to content

[Easy] Update Graphs.jl to 1.8, put is_tree under Graphs.jl export #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 13, 2023

Conversation

LinjianMa
Copy link
Contributor

No description provided.

@LinjianMa
Copy link
Contributor Author

CI should pass once ITensor/NamedGraphs.jl#31 is merged

@mtfishman
Copy link
Member

mtfishman commented Feb 13, 2023

I merged ITensor/NamedGraphs.jl#31. Could you bump the compat entry of NamedGraphs to 0.1.11? That should be registered now and includes your removal of NamedGraphs.is_tree in favor of Graphs.is_tree.

@mtfishman mtfishman mentioned this pull request Feb 13, 2023
@LinjianMa
Copy link
Contributor Author

I merged mtfishman/NamedGraphs.jl#31. Could you bump the compat entry of NamedGraphs to 0.1.11? That should be registered now and includes your removal of NamedGraphs.is_tree in favor of Graphs.is_tree.

Sure, done

@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2023

Codecov Report

Merging #65 (7164c92) into main (3df4c84) will increase coverage by 0.70%.
The diff coverage is 98.92%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main      #65      +/-   ##
==========================================
+ Coverage   77.73%   78.44%   +0.70%     
==========================================
  Files          55       56       +1     
  Lines        2834     2927      +93     
==========================================
+ Hits         2203     2296      +93     
  Misses        631      631              
Impacted Files Coverage Δ
src/ITensorNetworks.jl 77.77% <ø> (ø)
src/binary_tree_partition.jl 98.86% <98.86%> (ø)
src/mincut.jl 94.87% <100.00%> (+0.22%) ⬆️
src/itensornetwork.jl 86.20% <0.00%> (+0.86%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mtfishman mtfishman merged commit d197854 into ITensor:main Feb 13, 2023
@LinjianMa LinjianMa deleted the istree branch February 21, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants