[binary_tree_partition] [1/2]: Add mincut helper functions and introduce _binary_tree_partition_inds
#42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinjianMa
changed the title
inds_binary_tree_binary_tree_partition_inds
LinjianMa
changed the title
_binary_tree_partition_inds_binary_tree_partition_inds
|
@mtfishman I have made changes based on our last discussion. Could you review this? |
mtfishman
reviewed
Jan 25, 2023
mtfishman
reviewed
Jan 25, 2023
|
@mtfishman could you approve the workflow for this PR? |
|
Looks good, thanks! I like the new function names. |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #42 +/- ##
==========================================
+ Coverage 76.47% 77.93% +1.45%
==========================================
Files 52 55 +3
Lines 2725 2900 +175
==========================================
+ Hits 2084 2260 +176
+ Misses 641 640 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GraphsFlows.mincutandmincut_partitionsinds_binary_treeandinds_mps_order. For a given network, the first one outputs a binary tree of uncontract inds, and the second one outputs an inds order that can be used to approximate the network by an MPS.