Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Error In Forming RDM #23

Merged
merged 7 commits into from
Dec 9, 2022
Merged

Fixed Error In Forming RDM #23

merged 7 commits into from
Dec 9, 2022

Conversation

JoeyT1994
Copy link
Contributor

Now account for the fact combiners is a directed data graph.

src/beliefpropagation.jl Outdated Show resolved Hide resolved
@mtfishman
Copy link
Member

Glad to see this part can be simplified. Could you add a test for this function?

@JoeyT1994
Copy link
Contributor Author

Glad to see this part can be simplified. Could you add a test for this function?

I have added a testing unit for this now!

@mtfishman
Copy link
Member

Would Metis work instead of KaHyPar for the test? Unfortunately it is a bit awkward getting the automatic testing working with KaHyPar because of the installation issues on Windows.

@JoeyT1994
Copy link
Contributor Author

Good idea, I have changed it and the tests appear to be passing with Metis so I will use that for the testing.

@mtfishman
Copy link
Member

Could you add the line:

LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"

to test/Project.toml? That will allow the tests to automatically install the LinearAlgebra package.

@JoeyT1994
Copy link
Contributor Author

LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"

@JoeyT1994 JoeyT1994 closed this Dec 8, 2022
@JoeyT1994 JoeyT1994 reopened this Dec 8, 2022
@JoeyT1994
Copy link
Contributor Author

Added

Could you add the line:

LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"

to test/Project.toml? That will allow the tests to automatically install the LinearAlgebra package.

Sure, I added this.

@mtfishman
Copy link
Member

Thanks!

@mtfishman mtfishman merged commit 1c45db7 into ITensor:main Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants