-
Notifications
You must be signed in to change notification settings - Fork 19
Update gauge_walk functionality and fix bug in VidalITensorNetwork
#222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtfishman
reviewed
Mar 31, 2025
mtfishman
reviewed
Mar 31, 2025
mtfishman
pushed a commit
that referenced
this pull request
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the parts of PR #219 which were just quality of life improvements to the code.
Specifically the function for finding the
tree_gauge
to move the gauge of a tree tensor network from one region to another has been separated out so the path finding is done by a separategauge_path
function that operates on an abstract graph independent of the concept of anITensorNetwork
(which will be utilized in the upcomingmaximize_bilinearform
function).A bug is also fixed in the
apply
function for theVidalITensorNetwork
type.