-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes to alternating_update default printing #201
Conversation
I tested the current version and it works well. I would have liked to make a unit test, and while I would know how for a custom printer, here it's the default printer so I couldn't think of a good way except for a kind of test that explicitly checks the stdout output. |
Yeah, testing printing is tricky, since we don't want them to be too specific or else they are constantly breaking, and then we need to update tests any time we change how something prints. Maybe you could add a test that checks that at least a certain number of lines are printed by default, and that the output contains certain strings we expect, like |
The tests were working yesterday, except for the documentation, but now are failing. One possible issue, though it may be a red herring, is that on my machine I can't install a testing dependency, "OrdinaryDiffEq" because of a version compatibility issue. (The Pkg error message is quite long and I don't know how to read it, unfortunately.) |
I remember seeing |
@emstoudenmire the Windows tests passed, maybe the tests are just timing out or failing for some other non-Julia-specific reason. |
I'm glad those passed. So then we can be pretty sure the code is ok. (The relevant tests were passing locally for me too, I was just having issues running the entire testing suite for some reason.) Ready to merge? |
This PR fixes an issue where the
outputlevel
keyword to thedmrg
function does not produce any output. (This was noticed when calling it from the TNS solver code, just for some background context.) The changes include:region_printer
andsweep_printer
to use the definitions in defaults.jl for both interfaces toalternating_update
inserter_kwargs
into theall_kwargs
named tuple inregion_update
so that parameters likecutoff
will be available to the printersdefault_region_printer
has defaults (ofnothing
) for the valuescutoff
,maxdim
, andmindim
to make that function robust (i.e. not to assume all of these will be passed, since the current pattern was crashing in cases where only, say,cutoff
was passed into theinserter_kwargs
)