🎨 Align map load test with ui workflow #8417
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8417 +/- ##
==========================================
+ Coverage 87.89% 87.91% +0.01%
==========================================
Files 1953 1953
Lines 76045 76045
Branches 1341 1341
==========================================
+ Hits 66843 66855 +12
+ Misses 8801 8789 -12
Partials 401 401
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
pcrespov
approved these changes
Sep 25, 2025
| items = response.json().get("items", []) | ||
| statuses = [item.get("status", {}) for item in items] | ||
| all_job_statuses.extend( | ||
| [status.get("status", None) for status in statuses if status] |
There was a problem hiding this comment.
MINOR: i really find strange when we embed the same keys twice ... for instance
{
"status":
{
"status": ...
}I wonder why we do this? :-)
🧪 CI InsightsHere's what we observed from your CI run for b86d506. 🟢 All jobs passed!But CI Insights is watching 👀 |
sanderegg
approved these changes
Sep 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
GET /v0/function_jobsinstead ofGET /v0/function_job_collections/{function_job_collection_id}/status.Related issue/s
How to test
Dev-ops