🎨 [Frontend] Grouped list view #7845
Open
+65
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rc-simcore into feature/group-s4l-services
odeimaiz
added
t:enhancement
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the grouped view in both the Tutorial and App browser so that list mode view is now supported for grouped containers. The changes include:
- Refactoring the flat list creation and group container creation in ResourceContainerManager to support list mode.
- Removing the forced grid mode in group changes in ResourceBrowserBase.
- Adding a new "mode" property and associated logic in GroupedCardContainer with updated padding and event propagation.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| services/static-webserver/client/source/class/osparc/dashboard/ResourceContainerManager.js | Refactored __createFlatList and __createGroupContainer methods to support dynamic mode changes using a new __modeChanged helper |
| services/static-webserver/client/source/class/osparc/dashboard/ResourceBrowserBase.js | Removed forced grid mode when grouping is changed to allow list mode support |
| services/static-webserver/client/source/class/osparc/dashboard/GroupedCardContainer.js | Added a new "mode" property and updated __createContentContainer to adjust layout spacing and expansion based on mode |
Comments suppressed due to low confidence (1)
services/static-webserver/client/source/class/osparc/dashboard/ResourceContainerManager.js:314
- [nitpick] The __modeChanged function in ResourceContainerManager shares similar logic with the one in GroupedCardContainer. Consider refactoring this logic into a shared helper function to reduce code duplication.
const spacing = this.getMode() === "grid" ? osparc.dashboard.GridButtonBase.SPACING : osparc.dashboard.ListButtonBase.SPACING;
services/static-webserver/client/source/class/osparc/dashboard/GroupedCardContainer.js
Outdated
Show resolved
Hide resolved
…mcore into enh/grouped-list-view
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
The grouped containers in the Tutorial and App browser wouldn't support the list mode view. This PR brings this enhacement.
Related issue/s
How to test
Dev-ops